Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2283/Ad-blocker-off-by-default-in-Dawn #693

Closed
wants to merge 10 commits into from
Closed

GH-2283/Ad-blocker-off-by-default-in-Dawn #693

wants to merge 10 commits into from

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 19, 2021

PR made for review purposes only. This branch should not be merged into develop at this time.

Turns off ad blocking in Dawn only by default on install.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Default ad blocker to off on install in Dawn only
Loading status checks…
30520aa
@wlycdgr wlycdgr requested a review from christophertino as a code owner Feb 19, 2021
wlycdgr added 4 commits Feb 19, 2021
@wlycdgr
Move disabling of ad block in Dawn to guard against race condition
Loading status checks…
bcc2cf7
@wlycdgr
Ensure that onboarding code does not switch ad block on by default
Loading status checks…
7cfefe1
@wlycdgr
Change default enable_ad_block prop value to false in Dawn onboarding.
Loading status checks…
a2ce141
@wlycdgr
Disable adblocker Cliqz module on startup
Loading status checks…
0f7adfa
@wlycdgr wlycdgr requested a review from ghostery/extension as a code owner Feb 23, 2021
wlycdgr and others added 5 commits Feb 23, 2021
@wlycdgr
Reference ticket that motivates the Cliqz adblocker deactivation
Loading status checks…
634ce2a
@wlycdgr
Do not turn off ad blocker in background
Loading status checks…
68ae62e
@wlycdgr
Hardcode allowing Bing Ads bugs through
Loading status checks…
2feaf28
@wlycdgr
Only deactivate Cliqz adblocker module on startup if extension has ju…
Loading status checks…
c6cfdd6 
…st been installed
@christophertino
update prefs to disable ad-blocker
Verified
This commit was signed with the committer’s verified signature.
christophertino Christopher Tino
GPG key ID: 7DDE5EDA13A5D326 Learn about vigilant mode.
Loading status checks…
31cf928
@wlycdgr wlycdgr changed the title GH-2283/Ad-blocker-off-by-default-in-Dawn (NOT TO BE MERGED INTO DEVELOP AT ANY POINT) GH-2283/Ad-blocker-off-by-default-in-Dawn Mar 3, 2021
@wlycdgr wlycdgr changed the title (NOT TO BE MERGED INTO DEVELOP AT ANY POINT) GH-2283/Ad-blocker-off-by-default-in-Dawn (DO NOT MERGE AT ANY POINT) GH-2283/Ad-blocker-off-by-default-in-Dawn Mar 9, 2021
@wlycdgr wlycdgr changed the title (DO NOT MERGE AT ANY POINT) GH-2283/Ad-blocker-off-by-default-in-Dawn GH-2283/Ad-blocker-off-by-default-in-Dawn Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@ghostery/extension Extension

Assignees
No one assigned
Labels
Never Merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino