GH-2291: Add onboarding Step 0 ping #698
Merged
Conversation
|
These changes look good but let's make sure that the ping is actually getting sent before approval |
|
Found the issue and pushed a fix. I'm able to see the correct values coming up in the Network tab now. |
|
Smoked tested. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds a ping for the Welcome screen when setup is started through the addition of appropriate
dawn_setup_number. I've added the value as a constant inOnboardingConstants.js, but I can remove that and just include the value directly if that's overkill.