Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2291: Add onboarding Step 0 ping #698

Merged
merged 3 commits into from Mar 15, 2021
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Fix ping not sending from Welcome

  • Loading branch information
leuryr committed Mar 15, 2021
commit 11086396ac7fd13b2178ec91967562bb6604f10b
@@ -14,7 +14,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { NavLink } from 'react-router-dom';
import { WELCOME, SETUP_STARTED } from '../../OnboardingView/OnboardingConstants';
import { ONBOARDING, WELCOME, SETUP_STARTED } from '../../OnboardingView/OnboardingConstants';

/**
* A Functional React component for rendering the Browser Welcome View
@@ -29,7 +29,7 @@ const WelcomeView = (props) => {
<div className="WelcomeView__title">{t('ghostery_dawn_onboarding_welcome')}</div>
<div className="WelcomeView__subtitle">{t('ghostery_dawn_onboarding_welcome_message')}</div>
<img className="WelcomeView__rocketShip" src="/app/images/hub/welcome/rocketShip.png" />
<NavLink className="WelcomeView__ctaButton" to="/onboarding/1" onClick={() => setSetupStep({ setup_step: WELCOME, dawn_setup_number: SETUP_STARTED, origin: WELCOME })}>
<NavLink className="WelcomeView__ctaButton" to="/onboarding/1" onClick={() => setSetupStep({ setup_step: WELCOME, dawn_setup_number: SETUP_STARTED, origin: ONBOARDING })}>
<span>{t('ghostery_dawn_onboarding_lets_do_this')}</span>
</NavLink>
</div>
ProTip! Use n and p to navigate between commits in a pull request.