Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2264: Align plan select boxes #699

Merged
merged 2 commits into from Mar 22, 2021
Merged

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 22, 2021

  • Fixes plan box sizing on Choose Plan view when Basic user picks Glow

  • Updates some margins to bring Choose Plan and Default Search views closer to spec

  • Have you followed the guidelines in CONTRIBUTING.md?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Have you added an explanation of what your changes do?

  • Does your submission pass tests?

  • Did you lint your code prior to submission?

wlycdgr added 2 commits Mar 22, 2021
… & improve appearance. Tweak some margins on Default Search and Choose Plan views to match specs and improve appearance.
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

Sweet fix. LGTM.

@wlycdgr wlycdgr added this to the 8.5.6 milestone Mar 22, 2021
@christophertino christophertino merged commit 0a81853 into develop Mar 22, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2264/align-plan-select-boxes branch Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants