Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2264, GH-2309: Choose plan view fixes #700

Merged
merged 5 commits into from Mar 23, 2021
Merged

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 23, 2021

  • Fix feature copy sizing in Dawn (at the cost of breaking it in Chrome, but since the onboarding is Dawn only I chose not to do UA-based conditional CSS class application like we are forced to in the old hub)

  • Fix CTA button alignment on Premium user version of view

  • Ensure that we always display the correct subheader copy for the current user state & search selection combo

  • Have you followed the guidelines in CONTRIBUTING.md?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Have you added an explanation of what your changes do?

  • Does your submission pass tests?

  • Did you lint your code prior to submission?

@wlycdgr wlycdgr requested review from benstrumeyer and christophertino Mar 23, 2021
@wlycdgr wlycdgr added this to the 8.5.6 milestone Mar 23, 2021
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

LGTM 👍

@christophertino christophertino merged commit 53c7f16 into develop Mar 23, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the Choose-Plan-View-fixes branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants