Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2311/bugfix/other-search-confirmation-modal-alignment #701

Merged
merged 1 commit into from Mar 29, 2021
Merged

GH-2311/bugfix/other-search-confirmation-modal-alignment #701

merged 1 commit into from Mar 29, 2021

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 29, 2021

Fix alignment of main content in Other search confirmation modal in Dawn onboarding

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix alignment of main content in other search engine confirmation modal
Loading status checks…
351e83b
@wlycdgr wlycdgr requested review from leuryr and benstrumeyer Mar 29, 2021
@benstrumeyer
benstrumeyer approved these changes Mar 29, 2021
View changes
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

LGTM!
@christophertino
christophertino approved these changes Mar 29, 2021
View changes
@christophertino christophertino merged commit f1a1085 into develop Mar 29, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2311/bugfix/other-search-modal-formatting branch Mar 29, 2021
@christophertino christophertino added this to the 8.5.6 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@benstrumeyer benstrumeyer

@leuryr leuryr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @christophertino @benstrumeyer