Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2285/bugfix/do-not-sign-out-from-onboarding-on-ghosty-navigation #702

Merged
merged 1 commit into from Mar 30, 2021
Merged

GH-2285/bugfix/do-not-sign-out-from-onboarding-on-ghosty-navigation #702

merged 1 commit into from Mar 30, 2021

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 30, 2021

Do not sign user out if they navigate back to the Sign In step by clicking the Step 1 Ghosty in the onboarding progress bar

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Do not sign out user who clicks on onboarding Step 1 Ghosty
Loading status checks…
7f58282
@wlycdgr wlycdgr requested a review from leuryr Mar 30, 2021
@leuryr
leuryr approved these changes Mar 30, 2021
View changes
Copy link
Contributor

@leuryr leuryr left a comment

LGTM. That lines added:lines removed ratio looking 👌🏽 haha.
@christophertino
christophertino approved these changes Mar 30, 2021
View changes
@christophertino christophertino added this to the 8.5.6 milestone Mar 30, 2021
@christophertino christophertino merged commit 9982cb3 into develop Mar 30, 2021
1 check passed
1 check passed
@github-actions
lint-and-test
Details
@christophertino christophertino deleted the GH-2285/bugfix/do-not-sign-out-from-onboarding-on-ghosty-navigation branch Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@leuryr leuryr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @christophertino @leuryr