Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hotdog signals #73

Merged
merged 4 commits into from May 23, 2018
Merged

fix hotdog signals #73

merged 4 commits into from May 23, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented May 22, 2018

fix the following signals:

offer_ca_action
offer_closed_hotdog
offer_notification_hotdog
offer_click_hotdog
@trickpattyFH20
fix hotdog signals
Loading status checks…
d7555f0 
fix ca_action signal
@trickpattyFH20 trickpattyFH20 requested a review from ghostery/ghostery as a code owner May 22, 2018
@trickpattyFH20 trickpattyFH20 requested a review from jsignanini May 22, 2018
@trickpattyFH20
fix about rewards signal
Loading status checks…
f1a97a7
@trickpattyFH20
lint
Loading status checks…
0ac86dd
@trickpattyFH20
Copy link
Contributor Author

@trickpattyFH20 trickpattyFH20 commented May 22, 2018

this will fix GH-844
@jsignanini
jsignanini approved these changes May 23, 2018
View changes
@jsignanini
Merge branch 'develop' into feature/rewards-integration
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
230c833
@jsignanini jsignanini merged commit 06e264d into develop May 23, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/rewards-integration branch May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@trickpattyFH20 @jsignanini