Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1071 - Remove cap on showing of banners #74

Merged
merged 5 commits into from May 23, 2018
Merged

GH-1071 - Remove cap on showing of banners #74

merged 5 commits into from May 23, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented May 22, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [ x] Did you lint your code prior to submission?
zarembsky added 2 commits May 22, 2018
@zarembsky
Fixing GH-1071
0e9a704
@zarembsky
Additional fixes for GH-1071
Loading status checks…
052b75c
@zarembsky zarembsky changed the base branch from master to develop May 22, 2018
@zarembsky
Lint fixes
Loading status checks…
526fc75
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner May 22, 2018
@zarembsky zarembsky requested a review from christophertino May 23, 2018
@jsignanini
Merge branch 'develop' into feature/GH-1071
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a7d1f67
@christophertino
christophertino approved these changes May 23, 2018
View changes
@christophertino
Merge branch 'develop' into feature/GH-1071
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6c47371
@christophertino christophertino merged commit 9a4ba3e into develop May 23, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@zarembsky zarembsky deleted the feature/GH-1071 branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @christophertino @jsignanini