Additional fixes for GH-1071

app/panel/reducers/panel.js

@@ -242,7 +242,7 @@ const _showNotification = (state, action) => {
  */
 const _closeNotification = (state, action) => {
 	return {
-		notificationShown: (action.data.banner_status_name === 'temp_banner_status') ? false : true
+		notificationShown: false
 	};
 };
 

src/classes/Conf.js

@@ -75,6 +75,15 @@ const handler = {
 			}
 		}
 
+		//Adjust banner statuses, as they used to be objects
+		//while now they are booleans. This filter covers syncing.
+		if (key === 'reload_banner_status' ||
+			key === 'trackers_banner_status') {
+			if(value && (typeof value === 'object')) {
+				value = !!value.show;
+			}
+		}
+
 		target[key] = value;
 
 		// Don't save to storage while background::init() called.

src/classes/ConfData.js

@@ -77,6 +77,22 @@ class ConfData {
 				_setProp('previous_version', this.previous_version);
 			}
 
+			// Transfer legacy banner statuses which used to be objects
+			const { reload_banner_status, trackers_banner_status} = data;
+			if(reload_banner_status && typeof reload_banner_status === 'object') {
+				this.reload_banner_status = !!reload_banner_status.show;
+				_setProp('reload_banner_status', this.reload_banner_status);
+			} else {
+				_initProperty('reload_banner_status', true);
+			}
+
+			if(trackers_banner_status && typeof trackers_banner_status === 'object') {
+				this.trackers_banner_status = !!trackers_banner_status.show;
+				_setProp('trackers_banner_status', this.trackers_banner_status);
+			} else {
+				_initProperty('trackers_banner_status', true);
+			}
+
 			// simple props
 			_initProperty('alert_bubble_pos', 'br');
 			_initProperty('alert_bubble_timeout', 15);
@@ -116,8 +132,6 @@ class ConfData {
 			_initProperty('setup_step', 0);
 			_initProperty('setup_path', 0);
 			_initProperty('setup_block', 1);
-			_initProperty('reload_banner_status', true);
-			_initProperty('trackers_banner_status', true);
 
 			// Complex props
 			_initProperty('bugs', {});