Additional fix for GH-1071 (removing caps on banners). Banner parameters should be exported/pushed as objects. #81
Conversation
Contributor
zarembsky
commented
May 25, 2018
|
|
Banner parameters should be exported/pushed as objects so as to not break pre-8.2 Ghostery versions out there and sync properly. |
|
@zarembsky Should we also handle a similar case when pulling settings? |
|
This case is already taken care of in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.