Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fix for GH-1071 (removing caps on banners). Banner parameters should be exported/pushed as objects. #81

Merged
merged 3 commits into from May 31, 2018
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Additional fix for GH-1071
  • Loading branch information
zarembsky committed May 25, 2018
commit 75bc3f3d753c9760ab46a6e974a1c51eb59877f3
@@ -118,8 +118,21 @@ export function getLoginInfo() {
*/
export function buildUserSettings() {
const settings = {};
const nowTime = Number(new Date().getTime());
SYNC_SET.forEach((key) => {
settings[key] = conf[key];
// Whenever we prepare data to be sent out
// we have to convert these two parameters to objects
// so that they may be imported by pre-8.2 version
if (key === 'reload_banner_status' ||
key === 'trackers_banner_status') {
settings[key] = {
dismissals: [],
show_time: nowTime,
show: conf[key]
};
} else {
settings[key] = conf[key];
}
});
return settings;
}
ProTip! Use n and p to navigate between commits in a pull request.