Changed from 'npm install' to 'yarn' in Jenkinsfile. Also minor changes. #83
Conversation
|
@sharath-cliqz please take upstream changes to Dockerfile too. An updated version of |
sharath-cliqz
force-pushed the
sharath-cliqz:android_browser
branch
from
5ce6053
to
1091a02
|
@sammacbeth Thanks, I added the changes from the Dockerfile. |
sharath-cliqz
force-pushed the
sharath-cliqz:android_browser
branch
2 times, most recently
from
f3997ff
to
be39ca3
sharath-cliqz
force-pushed the
sharath-cliqz:android_browser
branch
from
be39ca3
to
fe11125
| sh 'sed -i \'s/global.__DEV__/true/1\' node_modules/browser-core/build/core/console.js' | ||
| withGithubCredentials { | ||
| sh 'moab makezip' | ||
| withEnv(["NO_LINT=true"]) { |
luciancor
May 28, 2018
Contributor
@christophertino is this step always required?
Will merge this PR to keep the train moving but we probably need to double check this again before merging back to your branches (this and probably many more :) )
@christophertino is this step always required?
Will merge this PR to keep the train moving but we probably need to double check this again before merging back to your branches (this and probably many more :) )
luciancor
merged commit 66ddef4
into
ghostery:android_browser
1 check failed
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.