Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language files. #84

Merged
merged 7 commits into from May 29, 2018
Merged

Language files. #84

merged 7 commits into from May 29, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented May 29, 2018

  • [ x] Have you followed the guidelines in CONTRIBUTING.md?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [ x] Does your submission pass tests?
  • [ x] Did you lint your code prior to submission?
zarembsky added 6 commits May 25, 2018
@zarembsky
Translated files
Loading status checks…
3075700
@zarembsky
Adding transifex script which restores placeholders.
Loading status checks…
aa87d5a
@zarembsky
Adding French. Still not ready : zh_TW and ja
Loading status checks…
0f36bd8
@zarembsky
Adding Taiwanese
Loading status checks…
0dd5e5c
@zarembsky
Adjustment to prevent unnecessary writes.
Loading status checks…
a8acf64
@zarembsky
Adding Japanese
Loading status checks…
40b93d6
@zarembsky zarembsky changed the base branch from master to develop May 29, 2018
@zarembsky
Copy link
Contributor Author

@zarembsky zarembsky commented May 29, 2018

Please double-check that English file is intact and run i18n-checker to verify integrity
@IAmThePan
IAmThePan approved these changes May 29, 2018
View changes
Copy link
Contributor

@IAmThePan IAmThePan left a comment

All languages have been added.
Transifex.js file looks good and works properly.
i18n-checker.js ran and found no problems with the translation files.
Approved
@IAmThePan
Merge branch 'develop' into feature/languages
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
2808332
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner May 29, 2018
@IAmThePan
IAmThePan approved these changes May 29, 2018
View changes
@christophertino
christophertino approved these changes May 29, 2018
View changes
@christophertino christophertino merged commit 7b398e6 into develop May 29, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the feature/languages branch May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmThePan IAmThePan

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @IAmThePan @christophertino