Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1160 update metric pings #88

Merged
merged 1 commit into from Jun 5, 2018
Merged

GH-1160 update metric pings #88

merged 1 commit into from Jun 5, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jun 4, 2018

  1. Update Rewards Pings to not send on all of [all, daily, weekly, monthly].
  2. Remove some old pings (and jsx)
  3. rewards_learn was being used in two different cases.
    a. keep the first case as is.
    b. create a new ping (rewards_first_learn_more) for the second case.
    (This required an update to the Metrics Server DB)
@IAmThePan
GH-1160 update metric pings
Loading status checks…
8d3d90b
@IAmThePan IAmThePan requested review from jsignanini and ghostery/ghostery as code owners Jun 4, 2018
@christophertino
christophertino approved these changes Jun 5, 2018
View changes
@christophertino christophertino merged commit 33ba439 into ghostery:develop Jun 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:feature/update-metrics branch Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @christophertino