Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GH-877, GH-872, GH-886, missing translations added. #9

Merged
merged 4 commits into from Mar 20, 2018
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev
Added return after reject.
  • Loading branch information
Serge Zarembsky
Serge Zarembsky committed Mar 20, 2018
commit 636c05cf47c51a13f368bc5f771f92cddd08ba65
@@ -541,13 +541,15 @@ export function injectScript(tabId, scriptfile, cssfile, runAt) {
if (chrome.runtime.lastError) {
log('injectScript error', chrome.runtime.lastError);
reject(new Error(chrome.runtime.lastError));
return;
}

if (cssfile) {
chrome.tabs.insertCSS(tabId, { file: cssfile, runAt }, () => {
if (chrome.runtime.lastError) {
log('insertCSS error', chrome.runtime.lastError);
reject(new Error(chrome.runtime.lastError));
return;
}

This comment has been minimized.

@jsignanini

jsignanini Mar 20, 2018
Member

@zarembsky add return; after this line to make sure we exit the function's execution please.

resolve();
});
ProTip! Use n and p to navigate between commits in a pull request.