Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1192 Left align title in Rewards Panel #95

Merged

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jun 8, 2018

Fix bug where rewards title "Ghostery Rewards" would be too long and would overlap with the On/Off Toggle.
Solution: Make "Ghostery Rewards" be left aligned instead of centered.
Also updated the unit tests.

@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Jun 8, 2018
@IAmThePan IAmThePan force-pushed the IAmThePan:feature/left-align-rewards-title branch from 49b91ff to c7a354a Jun 8, 2018
@IAmThePan IAmThePan force-pushed the IAmThePan:feature/left-align-rewards-title branch from 884b13c to 6a83e32 Jun 8, 2018
@jsignanini jsignanini merged commit 3ee9ce6 into ghostery:develop Jun 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:feature/left-align-rewards-title branch Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants