Android browser develop #97
Merged
Conversation
Contributor
mai-cliqz
commented
Jun 11, 2018
•
|
|
@christophertino can you guys please take a look at this PR? This is the Android Panel which should appear for the Firefox for Android users |
98de65c
to
495c065
dba44ed
to
26ba8cc
6fed6df
to
e4e7dd3
|
@mai-cliqz this looks solid. I think we could import some of the utils like msg.js and utils.js from the panel folder like we do for setup, rather than having duplicated code. See here We also need to add the license header to all the new files. ++ @IAmThePan for review |
4c8e798
to
cefcb09
cefcb09
to
74dbcae
|
Thank you very much for reviewing @christophertino. I have applied some changes based on your feedback. Please have a look again. |
|
@mai-cliqz There is a lot here. Two things that jump out at me are:
|
|
@IAmThePan Thank you very much for your time.
|
ce5420e
into
ghostery:develop
1 check passed
1 check passed
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
* Update package.json * Allow getting cliqzModuleData from specified tab * Control Center for Android * Allow user to click on a category's checkbox to block/unblock all trackers inside * Add the license header to all the new files
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
* Update package.json * Allow getting cliqzModuleData from specified tab * Control Center for Android * Allow user to click on a category's checkbox to block/unblock all trackers inside * Add the license header to all the new files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.