Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engine choice #1

Merged
merged 5 commits into from Oct 15, 2020
Merged

Search engine choice #1

merged 5 commits into from Oct 15, 2020

Conversation

@chrmod
Copy link
Member

@chrmod chrmod commented Oct 15, 2020

First screen from Search Engine Choice experience

It implements:

  • shows once as onboarding
  • allow user to select default search engine
  • search engine set with experiment API

Screenshot 2020-10-15 at 17 11 42

@chrmod chrmod requested a review from sammacbeth Oct 15, 2020
Copy link
Contributor

@sammacbeth sammacbeth left a comment

Looks good. Just a couple of nits

src/assets/GhoserySearch.svg Outdated Show resolved Hide resolved
src/experiment_apis/ghostery_schema.json Outdated Show resolved Hide resolved
src/pages/choice-screen.html Show resolved Hide resolved
src/pages/choice-screen.html Show resolved Hide resolved
@chrmod chrmod merged commit 50a3fad into master Oct 15, 2020
@chrmod chrmod deleted the search-engine-choice branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants