Fix: Refresh access_token if expired

[fcjr]

The browser removes the access_token if expired however it's likely we have a refresh_token available to get a new one, so rather than failing and prompting the user to sign in again, we can just try to renew here first.

[sammacbeth]

I think a simpler solution would be just to call call AccessToken.refresh() if we're missing an access token, then if this is successful generateTokens() will automatically get called again.

[fcjr]

I think a simpler solution would be just to call call AccessToken.refresh() if we're missing an access token, then if this is successful generateTokens() will automatically get called again.

The problem there is that even though generateTokens is called again async; in the request that needs the tokens (here:

ghostery-search-extension/src/background.js

Line 76 in 5fa5eec

const token = await tokenPool.getToken();

) getToken will still return undefined causing the search to fail.

[sammacbeth]

I think a simpler solution would be just to call call AccessToken.refresh() if we're missing an access token, then if this is successful generateTokens() will automatically get called again.

The problem there is that even though generateTokens is called again async; in the request that needs the tokens (here:

ghostery-search-extension/src/background.js

Line 76 in 5fa5eec

const token = await tokenPool.getToken();

) getToken will still return undefined causing the search to fail.

I see. I'm not sure holding the outgoing search request before we get tokens is the right approach. Ideally we should always have tokens ready for sync usage if the user is logged in. This could then be easily fixed by just fetching tokens on startup, then we can keep the token pool stocked up over time in the background.

I think that's a simpler solution architecture-wise than making the AccessToken.get() function do a refresh if needed, and hold off resolution until the cookie update event fires (which it may never do).

[fcjr]

I think a simpler solution would be just to call call AccessToken.refresh() if we're missing an access token, then if this is successful generateTokens() will automatically get called again.

The problem there is that even though generateTokens is called again async; in the request that needs the tokens (here:

ghostery-search-extension/src/background.js

Line 76 in 5fa5eec

const token = await tokenPool.getToken();

) getToken will still return undefined causing the search to fail.

I see. I'm not sure holding the outgoing search request before we get tokens is the right approach. Ideally we should always have tokens ready for sync usage if the user is logged in. This could then be easily fixed by just fetching tokens on startup, then we can keep the token pool stocked up over time in the background.

I think that's a simpler solution architecture-wise than making the AccessToken.get() function do a refresh if needed, and hold off resolution until the cookie update event fires (which it may never do).

What about just trying to refresh the token in these two scenarios:

1. it is not found on startup
2. on a removed event

this should basically mean the pool should always be populated as it will always cause generateTokens to be called on startup if possible, and it will keep the access_token refreshed (which in turn keeps the token pool filled)