don't refresh on overwrite #25
Merged
Conversation
From reading the onChanged docs this looks to be the correct approx. A cookie removal with the cause as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Refreshing on overwrite could cause the extension to keep trying to refresh the token when it does not need to, @sammacbeth not 100% sure but we might want to also not destroy it if the remove cause is overwrite as well?