Skip to content

/ ghostery-search-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose logged-in state to ghosterysearch page via content-script. #34

Merged
merged 4 commits into from Dec 4, 2020
Merged

Expose logged-in state to ghosterysearch page via content-script. #34

merged 4 commits into from Dec 4, 2020

Conversation

@sammacbeth
Copy link
Contributor

@sammacbeth sammacbeth commented Dec 3, 2020

Instead of sending flags to the search endpoint, add classes to html in content script so we can toggle features with CSS.
@sammacbeth
Expose logged-in state to ghosterysearch page via content-script.
027fcfb
@sammacbeth sammacbeth requested a review from chrmod Dec 3, 2020
@sammacbeth
Remove logging
c1f8dfd
@chrmod
chrmod reviewed Dec 4, 2020
View changes
src/content/is-ghostery-browser.js Outdated Show resolved Hide resolved
src/status.js Outdated Show resolved Hide resolved
src/status.js Outdated Show resolved Hide resolved
sammacbeth added 2 commits Dec 4, 2020
@sammacbeth
Remove async from is-ghostery-browser function.
c0ca246
@sammacbeth
Unregister old content-script before registering the new one
756d9d6
@chrmod
chrmod approved these changes Dec 4, 2020
View changes
@chrmod chrmod merged commit 727c5d0 into master Dec 4, 2020
@chrmod chrmod deleted the sam/expose-logged-in branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmod chrmod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sammacbeth @chrmod