avoid innerHTML

ghostery · sammacbeth · Dec 8, 2020 · Dec 8, 2020 · Dec 8, 2020 · Dec 8, 2020
commit 10e74e6026135d34f898ba8cf889d97d7c799304
diff --git a/src/content/additional-search-engines.js b/src/content/additional-search-engines.js
@@ -4,7 +4,9 @@
 
   function cleanup() {
     const $searchEngines = document.querySelector('.search-engines');
-    $searchEngines.innerHTML = '';
+    while ($searchEngines.firstChild) {
+      $searchEngines.removeChild(searchEngines.firstChild);
+    }
   }
 
   async function addSearchEngines() {

diff --git a/src/content/top-sites.js b/src/content/top-sites.js
@@ -4,7 +4,9 @@
 
   function cleanup() {
     const $topsites = document.querySelector('.top-sites');
-    $topsites.innerHTML = '';
+    while ($topsites.firstChild) {
+      $topsites.removeChild(topsites.firstChild);
+    }
   }
 
   async function loadTopSites() {