Skip to content

/ ghostery-search-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #35

Merged
merged 4 commits into from Dec 8, 2020
+22 −50
Merged

Cleanup #35

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
662cdfa
Remove redundant code for JWT parsing
chrmod Dec 8, 2020
bca9693
Insert top sites and search bar hijack on landing page only
chrmod Dec 8, 2020
882139b
Additional Search Engines template usage
chrmod Dec 8, 2020
10e74e6
avoid innerHTML
chrmod Dec 8, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next

Additional Search Engines template usage

  • Loading branch information
@chrmod
chrmod committed Dec 8, 2020
commit 882139bc58136d078689ca7f512b932ddeb41ed4
45 src/content/additional-search-engines.js
View file
Open in desktop
@@ -3,35 +3,21 @@
(async function () {

function cleanup() {
const $content = document.querySelector('.other-search-engines');
const $searchEngines = document.querySelector('.searchengines');
if ($searchEngines) {
$content.removeChild($searchEngines);
}
const $searchEngines = document.querySelector('.search-engines');
$searchEngines.innerHTML = '';
This conversation was marked as resolved by chrmod

This comment has been minimized.

Sign in to view
@sammacbeth

sammacbeth Dec 8, 2020
Contributor

I think MDN review will flag use of innerHTML. While this use is innocuous, we should try to avoid using it.
}

async function addSearchEngines() {
const query = new URLSearchParams(window.location.search).get('q');
const $content = document.querySelector('.other-search-engines');
const $searchEngineTemplate = document.querySelector('#search-engine-template');
const searchEngines = await browser.runtime.sendMessage({
action: 'getSearchEngines',
});
const $searchEnginesWrapper = document.createElement('div');
$searchEnginesWrapper.classList.add('searchengines');
$searchEnginesWrapper.style.display = 'flex';
$searchEnginesWrapper.style.flexDirection = 'row';
$searchEnginesWrapper.style.margin = '40px 0 40px 0';
$searchEnginesWrapper.style.flexWrap = 'wrap';
const $searchEngines = document.querySelector('.search-engines');

searchEngines.forEach(engine => {
const $engine = document.createElement('a');
$engine.style.display = 'flex';
$engine.style.flexDirection = 'column';
$engine.style.alignItems = 'center';
$engine.style.margin = '10px 7px';
$engine.style.textDecoration = 'none';
$engine.style.color = 'black';
$engine.style.cursor = 'pointer';
const $engine = $searchEngineTemplate.content.cloneNode(true);
$engine.querySelector('.search-engine-name').innerText = engine.name;
$engine.addEventListener('click', () => {
browser.runtime.sendMessage({
action: 'search',
@@ -42,25 +28,8 @@
});
});

const $favicon = document.createElement('img');
$favicon.setAttribute('src', engine.favIconUrl);
$favicon.style.height = '24px';
$favicon.style.width = '24px';
$favicon.style.boxShadow = 'inset 0 0 0 1px rgba(249, 249, 250, 0.2), 0 1px 8px 0 rgba(12, 12, 13, 0.2)';
$favicon.style.transition = 'box-shadow 150ms';
$favicon.style.borderRadius = '5px';
$favicon.style.backgroundColor = 'white';
$engine.appendChild($favicon);

const $title = document.createElement('span');
$title.innerText = engine.name;
$title.style.marginTop = '5px';
$engine.appendChild($title);

$searchEnginesWrapper.appendChild($engine);
$searchEngines.appendChild($engine);
});

$content.appendChild($searchEnginesWrapper);
}

if (document.readyState === 'complete' || document.readyState === 'interactive') {
ProTip! Use n and p to navigate between commits in a pull request.