Skip to content

/ ghostery-search-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebranding #42

Merged
merged 5 commits into from Jan 18, 2021
+50 −14
Merged

Rebranding #42

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df0f023
New name - Ghostery Glow
chrmod Jan 18, 2021
cce1cf9
Ghostery Dawn detection
chrmod Jan 18, 2021
e6aa417
Not top sites in incognito windows - fix #40
chrmod Jan 18, 2021
15ffb48
version bump
chrmod Jan 18, 2021
faf5470
Handle legacy domain ghosterysearch.com gracefully
chrmod Jan 18, 2021
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev

Handle legacy domain ghosterysearch.com gracefully

  • Loading branch information
@chrmod
chrmod committed Jan 18, 2021
commit faf54700d9989e3e3be6f6c2bbf38b8645fa1c35
4 src/background.js
View file
Open in desktop
@@ -111,7 +111,7 @@ async function start() {
return {
requestHeaders,
};
}, { urls: [`${SERP_BASE_URL}/search*`]}, ["blocking", "requestHeaders"]);
}, { urls: [`${SERP_BASE_URL}/search*`, USE_STAGING ? 'https://staging.ghosterysearch.com/search*' : 'https://ghosterysearch.com/search*']}, ["blocking", "requestHeaders"]);
This conversation was marked as resolved by chrmod

This comment has been minimized.

Sign in to view
@remusao

remusao Jan 18, 2021

Should this be:

Suggested change
}, { urls: [`${SERP_BASE_URL}/search*`, USE_STAGING ? 'https://staging.ghosterysearch.com/search*' : 'https://ghosterysearch.com/search*']}, ["blocking", "requestHeaders"]);
}, { urls: [`${SERP_BASE_URL}/search*`, USE_STAGING ? 'https://staging.glowstery.com/search*' : 'https://glowstery.com/search*']}, ["blocking", "requestHeaders"]);

This comment has been minimized.

Sign in to view
@chrmod

chrmod Jan 18, 2021
Author Member

No, *.ghosterysearch.com is from now considered deprecated and will be removed in next release. This is just for transition period.

// TODO: this should only run in Ghostery Dawn
This conversation was marked as resolved by chrmod

This comment has been minimized.

Sign in to view
@remusao

remusao Jan 18, 2021

Is there already a ticket for this?

This comment has been minimized.

Sign in to view
@chrmod

chrmod Jan 18, 2021
Author Member

Nope.
browser.webRequest.onBeforeSendHeaders.addListener(async (details) => {
@@ -123,7 +123,7 @@ async function start() {
return {
requestHeaders,
};
}, { urls: [`${SERP_BASE_URL}/*`]}, ["blocking", "requestHeaders"]);
}, { urls: [`${SERP_BASE_URL}/*`, USE_STAGING ? 'https://staging.ghosterysearch.com/search*' : 'https://ghosterysearch.com/search*']}, ["blocking", "requestHeaders"]);
}

browser.runtime.onMessage.addListener(async ({ action, args }, { tab }) => {
ProTip! Use n and p to navigate between commits in a pull request.