Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach authorization header to ghosterysearch.com/login #5

Merged
merged 2 commits into from Oct 20, 2020
Merged

Conversation

@chrmod
Copy link
Member

@chrmod chrmod commented Oct 19, 2020

No description provided.

@@ -1,3 +1,3 @@
let DEBUG = false;
let DEBUG = true;

This comment has been minimized.

@sammacbeth

sammacbeth Oct 20, 2020
Contributor

In future we could expose this on the window object to allow this to be toggled at runtime.

This comment has been minimized.

@chrmod

chrmod Oct 20, 2020
Author Member

ops, this should not get merged with debug set to true

This comment has been minimized.

@chrmod

chrmod Oct 20, 2020
Author Member

toggling it from window global would be lovely but it will require replacing webrequest listeners.

@sammacbeth sammacbeth merged commit 2146d16 into master Oct 20, 2020
chrmod added a commit to ghostery/user-agent-desktop that referenced this pull request Oct 20, 2020
@chrmod chrmod deleted the auth branch Oct 20, 2020
sammacbeth pushed a commit to ghostery/user-agent-desktop that referenced this pull request Oct 20, 2020
* Basic ghosterysearch login flow

Implemented in ghostery/ghostery-search-extension#5

* Update .workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants