Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach authorization header to ghosterysearch.com/login #5

Merged
merged 2 commits into from Oct 20, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev

Remove Access Token from memory when cookie is removed

  • Loading branch information
chrmod committed Oct 19, 2020
commit acddf6a9398ad73fc93d2f2440465bee10015ed4
@@ -44,6 +44,7 @@ const cookieListener = (changeInfo) => {

if (removed) {
AccessToken.destroy();
return;
}

AccessToken.set(cookie.value);
@@ -1,3 +1,3 @@
let DEBUG = false;
let DEBUG = true;

This comment has been minimized.

@sammacbeth

sammacbeth Oct 20, 2020
Contributor

In future we could expose this on the window object to allow this to be toggled at runtime.

This comment has been minimized.

@chrmod

chrmod Oct 20, 2020
Author Member

ops, this should not get merged with debug set to true

This comment has been minimized.

@chrmod

chrmod Oct 20, 2020
Author Member

toggling it from window global would be lovely but it will require replacing webrequest listeners.

let API_BASE_URL = DEBUG ? 'http://localhost:5000' : 'https://ghosterysearch.com';
let SERP_BASE_URL = DEBUG ? 'http://localhost' : 'https://ghosterysearch.com';
ProTip! Use n and p to navigate between commits in a pull request.