Signal C syscall in case of exception #1428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed at those functions defined in C extension modules which internally calls multiple syscalls. Usually they fail with
OSError
orWindowsError
. We have the error code and the message string but we don't know which syscall caused the error exactly. This is especially bad when receiving a bug report on Windows, since the single functions make invoke multiple syscalls. Instead of asking the user to debug the problem themselves we now pass a debug message string which produces an exception like this:When we only exercise one syscall there's no need to add the additional information.
I did this for Linux, OSX, Windows and FreeBSD.