OSX correct proc_pidinfo() handling #909

Merged
merged 7 commits into from Oct 5, 2016

Conversation

Projects
None yet
1 participant
@giampaolo
Owner

giampaolo commented Oct 5, 2016

The error handling of proc_pidinfo() was incorrect and could lead to raise OSError with no exception set for Process.open_files() and Process.connections() methods.
This PR refactors proc_pidinfo and invoke the DRY principle so that proc_pidinfo stays in a wrapper and the error handling occurs in there only.

@giampaolo giampaolo merged commit f06f4a8 into master Oct 5, 2016

0 of 4 checks passed

codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details

@giampaolo giampaolo deleted the osx-proc-pidinfo-refact branch Oct 5, 2016

@giampaolo giampaolo restored the osx-proc-pidinfo-refact branch Oct 5, 2016

@giampaolo giampaolo deleted the osx-proc-pidinfo-refact branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment