QUIT sent during a transfer causes a memory leak

[giampaolo]

From billiej...@gmail.com on July 29, 2009 23:12:40

What steps will reproduce the problem?  
1. start the server
2. connect with a client
3. start a file transfer (RETR, STOR... it doesn't matter)
4. during the transfer issue a QUIT command
5. wait for transfer to finish 

What is the expected output?  


What do you see instead?  
Once the transfer is finished it is expected that the client gets
disconnected by the server but this doesn't happen and the client will just
hang forever.

Internally the server will keep a reference to a FTPHandler instance which
will never be collected by the garbage collector as well as the connection
socket object, causing a memory leak.

The problem is that when the transfer is finished asynchat's
close_when_done() method is used instead of close().

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=119

[giampaolo]

From billiej...@gmail.com on July 29, 2009 14:21:20

Fixed as r615 .

Status: Finished

[giampaolo]

From billiej...@gmail.com on August 29, 2009 10:34:03

Status: FixedInSVN

[giampaolo]

From billiej...@gmail.com on September 13, 2009 13:56:15

Status: Fixed

[giampaolo]

From billiej...@gmail.com on September 13, 2009 14:01:52

This is now fixed and included as part of 0.5.2 version.

[giampaolo]

From g.rodola on August 11, 2010 15:20:02

Owner: g.rodola

[giampaolo]

From g.rodola on October 27, 2010 13:53:17

Adding "security" label as per: 
https://bugzilla.redhat.com/show_bug.cgi?id=646174

Labels: Security