Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIT sent during a transfer causes a memory leak #119

Closed
giampaolo opened this issue May 28, 2014 · 6 comments
Closed

QUIT sent during a transfer causes a memory leak #119

giampaolo opened this issue May 28, 2014 · 6 comments
Assignees
Labels
bug Component-Library imported Security

Comments

@giampaolo
Copy link
Owner

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on July 29, 2009 23:12:40

What steps will reproduce the problem?  
1. start the server
2. connect with a client
3. start a file transfer (RETR, STOR... it doesn't matter)
4. during the transfer issue a QUIT command
5. wait for transfer to finish 

What is the expected output?  


What do you see instead?  
Once the transfer is finished it is expected that the client gets
disconnected by the server but this doesn't happen and the client will just
hang forever.

Internally the server will keep a reference to a FTPHandler instance which
will never be collected by the garbage collector as well as the connection
socket object, causing a memory leak.

The problem is that when the transfer is finished asynchat's
close_when_done() method is used instead of close().

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=119

@giampaolo giampaolo self-assigned this May 28, 2014
@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on July 29, 2009 14:21:20

Fixed as r615 .

Status: Finished

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on August 29, 2009 10:34:03

Status: FixedInSVN

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on September 13, 2009 13:56:15

Status: Fixed

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on September 13, 2009 14:01:52

This is now fixed and included as part of 0.5.2 version.

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From g.rodola on August 11, 2010 15:20:02

Owner: g.rodola

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From g.rodola on October 27, 2010 13:53:17

Adding "security" label as per: 
https://bugzilla.redhat.com/show_bug.cgi?id=646174

Labels: Security

@giampaolo giampaolo closed this May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component-Library imported Security
Projects
None yet
Development

No branches or pull requests

1 participant