Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a max number of tries for finding unique filename on STOU #25

Closed
giampaolo opened this issue May 28, 2014 · 6 comments
Closed

Set a max number of tries for finding unique filename on STOU #25

giampaolo opened this issue May 28, 2014 · 6 comments

Comments

@giampaolo
Copy link
Owner

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on July 18, 2007 20:38:56

What steps will reproduce the problem?  
1. Connecting to FTPd.
2. Sending a lot of STOU requests. 

Please use labels and text to provide additional information.  
Every time a STOU is received we start an infinite while loop stopped only
when a name unique for the file is found. We should set a maximum number of
tries to create a unique filename (e.g. 99), so that we decrease the
chances of a DoS situation.

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=25

@giampaolo giampaolo self-assigned this May 28, 2014
@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on July 19, 2007 19:30:34

Fixed in SVN, revision #37 .
Jay Loden proposed an alternative solution based on tempfile module: 
http://groups.google.com/group/pyftpdlib/browse_thread/thread/ca89ac2e21b9bbfe 
As long as Jay shows some code up I mark this report as "Finished".

Status: Finished

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on August 06, 2007 02:54:58

Cc: -aleaxit -yanraber -jloden
Labels: Milestone-0.2.0

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on September 17, 2007 09:43:13

Status: Fixed

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on May 02, 2008 11:27:42

Labels: Version-0.1.1

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From billiej...@gmail.com on October 13, 2008 12:13:14

Labels: Component-Library

@giampaolo
Copy link
Owner Author

@giampaolo giampaolo commented May 28, 2014

From g.rodola on August 11, 2010 15:20:01

Owner: g.rodola

@giampaolo giampaolo closed this May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant