Stop buffering if extremely long lines are received

[giampaolo]

From billiej...@gmail.com on May 18, 2007 22:59:01

Method "collect_incoming_data" of "ftp_handler" class should stop buffering
if received lines are too long (possible Denial-of-Service attacks).
Patch:


class ftp_handler(asynchat.async_chat):

    [...]

    def collect_incoming_data(self, data):        
        self.in_buffer = self.in_buffer + data

+        if len(self.in_buffer) > 2048:

+            self.in_buffer = ""


    def found_terminator(self):        
        line = self.in_buffer.strip()

    [...]

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=3

[giampaolo]

From billiej...@gmail.com on July 19, 2007 19:07:25

Status: Finished
Cc: -aleaxit jloden yanraber

[giampaolo]

From billiej...@gmail.com on July 19, 2007 19:12:00

Fixed in SVN, revision #20

[giampaolo]

From billiej...@gmail.com on August 06, 2007 03:20:16

Labels: Milestone-0.2.0

[giampaolo]

From billiej...@gmail.com on September 17, 2007 09:29:53

Status: Fixed

[giampaolo]

From billiej...@gmail.com on May 02, 2008 11:27:42

Labels: Version-0.1.1

[giampaolo]

From billiej...@gmail.com on October 13, 2008 12:13:13

Labels: Component-Library

[giampaolo]

From g.rodola on August 11, 2010 15:20:00

Owner: g.rodola