Skip to content

Conversation

@webartifex
Copy link

... for an errors dictionary full of
inspectors without any errors, for example:

{
    'columns': {},
    'primary_keys': {},
    'foreign_keys': {},
    'indexes': {},
    'unique_constraints': {},
    'check_constraints': {},
}

... for an `errors` dictionary full of
inspectors without any errors, for example:

```
{
    'columns': {},
    'primary_keys': {},
    'foreign_keys': {},
    'indexes': {},
    'unique_constraints': {},
    'check_constraints': {},
}
```
@webartifex
Copy link
Author

The above example show an example where the two databases compared are identical.

The current not self.errors check in the is_match property gives the wrong answer: It thinks the two databases are not identical.

I did not check when this bug was introduced (must be v1 though) nor did I run the test suite. So, maybe some test cases need adjustment too.

@gianchub
Copy link
Owner

Much appreciated @webartifex :)
Will fix in #29
Will go out today in v1.0.4.

@gianchub gianchub closed this Nov 18, 2025
@webartifex
Copy link
Author

Your solution is way nicer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants