Skip to content

Gian Merlino
gianm

  • Imply
  • San Francisco, CA
  • Joined on Nov 22, 2011

Organizations

@druid-io @implydata
May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

^ this comment applies to all query types

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

I think I'd really like to see this stuff be more linked with the rest of the tests. We eventually want an automated performance testing system (#2823

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

I think we can remove this, it's pretty easy to add it back if we want.

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

hmm, I think ideally we should have benchmarks for a few levels of things. this will help us track down performance improvements and regressions mo…

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

or maybe there's some way to use yourkit + jmh better together.

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

hmm, is there a better approach we can take here? Having all these files with commented out code that are not part of the "official" benchmarks see…

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

dead code

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

let's just delete this, it's pretty easy to add back and dead code is annoying.

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

one day we'll want multiple benchmark queries that exercise different things.

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

[minor] I kinda prefer the IncrementalIndexSchema based constructor, the builder makes it easier to read what's going on.

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

this method doesn't look necessary?

May 6, 2016
gianm commented on pull request druid-io/druid#2875
@gianm

this method doesn't look necessary?

May 6, 2016
gianm commented on issue druid-io/tranquility#53
@gianm

FWIW the real fix for this issue is setting druidBeam.taskLocator = overlord, which will work starting in Druid 0.9.1. At that point this cycleBuck…

May 6, 2016
gianm commented on pull request druid-io/tranquility#72
@gianm

Hey @rohitkochar, really sorry for the delay on this one! #171 contains a similar patch that I think should work for you too (segment granularity m…

May 6, 2016
gianm commented on pull request druid-io/tranquility#169
@gianm

Do you mind trying that out and seeing if it works for you?

May 6, 2016
gianm commented on pull request druid-io/tranquility#169
@gianm

Thanks for the patch @boneill42. I tweaked it a bit (added tests, changed the modulus to 3, removed an extraneous shell script) and submitted it as #…

May 6, 2016
gianm opened pull request druid-io/tranquility#171
@gianm
Add some additional hourly cycling to minutely cycleBuckets
1 commit with 44 additions and 16 deletions
gianm created branch cycleBucket at gianm/tranquility
May 5, 2016
May 5, 2016
@gianm
gianm deleted branch sparkfix at gianm/tranquility
May 5, 2016
May 5, 2016
gianm commented on pull request druid-io/druid#2913
@gianm

merged, I'm not sure (@javasoze?), but looked at – that always helps :)

gianm deleted branch flattenSpec-docs at gianm/druid
May 5, 2016
May 5, 2016
gianm commented on pull request druid-io/druid#2924
@gianm

@schmee, that would be great, thanks!

May 5, 2016
gianm commented on issue druid-io/druid#2914
@gianm

It unfortunately does have to do with the schema, because the parser defines both the data format and the dimensions for the schema. IMO that is a …

May 5, 2016
gianm commented on pull request druid-io/druid#2913
@gianm

@xvrl, definitely, although we have not yet figured out the details of a proposal so there is nothing concrete to share yet. Hoping to have somethi…

May 5, 2016
gianm commented on issue druid-io/druid#2914
@gianm

Test the fields for equality individually? There's only 4, the test wouldn't be THAT verbose. That's probably more honest than implementing an equa…

May 5, 2016
gianm commented on issue druid-io/druid#2914
@gianm

Looking through production usages I don't see anything that would rely on equals/hashCode being semantic, so I think they're safe to remove. (could…

May 5, 2016
gianm commented on issue druid-io/druid#2914
@gianm

Since 74f4572 I don't think it's possible to have a semantic equals/hashCode impl for DataSchema that avoids creating the parser (which seems like …

May 5, 2016
gianm commented on pull request druid-io/tranquility#167
@gianm

removed

May 5, 2016
@gianm
Something went wrong with that request. Please try again.