Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommInfoRequest and CommInfoReply #697

Merged
merged 5 commits into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@emhoracek
Copy link
Contributor

commented Oct 4, 2016

To fix #694.

This adds support for comm_info_request. I added CommInfoRequest and CommInfoReply Messages and all the Aeson bits for both. The replyTo functions are faked out for now with empty maps.

@vaibhavsagar says what's currently here is enough to fix his issue, but it would be better to actually respond with a list of open comms. :) I plan on doing that next.

@emhoracek emhoracek changed the title Add CommInfoRequest and CommInfoResponse Add CommInfoRequest and CommInfoReply Oct 4, 2016

@emhoracek

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2016

I added a real response for comm_info_request, so it's ready for review.

@sumitsahrawat
Copy link
Collaborator

left a comment

Thanks for the work @emhoracek 👍

@sumitsahrawat

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2016

I'll let this idle for a couple of days so that @gibiansky can also review it if possible.

@sumitsahrawat sumitsahrawat merged commit 090ee84 into gibiansky:master Oct 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sumitsahrawat

This comment has been minimized.

Copy link
Collaborator

commented Oct 10, 2016

Thanks for the work 👍 @emhoracek and @vaibhavsagar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.