New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with GHC 8.2 #735

Merged
merged 7 commits into from Oct 15, 2017

Conversation

Projects
None yet
1 participant
@vaibhavsagar
Collaborator

vaibhavsagar commented Jul 31, 2017

I'd like to support GHC 8.2 by the time the Stackage LTS package set including it is released. I've updated the package bounds and now I'm running into a GHC API change between <=8.0 and 8.2 where extraPkgConfs seems to have been removed and the order of the list it expects has reversed.

To check the current progress, run nix-build release821.nix.

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch 3 times, most recently from e3a986d to 7670697 Aug 31, 2017

@vaibhavsagar vaibhavsagar changed the title from [WIP] Work with GHC 8.2.1 to Work with GHC 8.2.1 Aug 31, 2017

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Aug 31, 2017

Ready for testing! nix-build release821.nix should create a working notebook environment!

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Sep 6, 2017

I am confused by the test failures and wondering what I changed to cause them.

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch from 5806067 to 5806456 Sep 10, 2017

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch 5 times, most recently from 2a6a1ff to bbf24ae Sep 26, 2017

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch 2 times, most recently from ce7dc49 to 89d4788 Oct 14, 2017

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Oct 15, 2017

I was hoping that upgrading to a new enough resolver would make the problem go away, but I no longer think it will and there's an issue in the codebase that needs to be addressed. I've added a small failure.hs that demonstrates the failure on GHC 8.2 and works correctly with GHC 8.0:

$ stack ghci failure.hs
*Main> main
False

I'm reasonably sure the problem is with the initializeImports function.

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch 2 times, most recently from 876dcb3 to b0e67de Oct 15, 2017

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Oct 15, 2017

The issue appears to be that packages in GHC 8.0 and below are named e.g ihaskell-1.2.3.4 but in 8.2 they're just ihaskell. I'm getting a different error now, so I'll call that progress 🎉

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch 2 times, most recently from 7092631 to 2857367 Oct 15, 2017

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Oct 15, 2017

🎉 🎆 🍾

@vaibhavsagar

This comment has been minimized.

Collaborator

vaibhavsagar commented Oct 15, 2017

I'm going to split out release821.nix and the newer stack.yaml into a separate PR, and try to figure out how to test both 8.0 and 8.2 as part of the CI process.

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch from 2857367 to b5f4e16 Oct 15, 2017

@vaibhavsagar vaibhavsagar changed the title from Work with GHC 8.2.1 to Work with GHC 8.2 Oct 15, 2017

@vaibhavsagar vaibhavsagar force-pushed the ghc821-nix branch from b5f4e16 to 384a984 Oct 15, 2017

@vaibhavsagar vaibhavsagar merged commit 6dad100 into master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vaibhavsagar vaibhavsagar deleted the ghc821-nix branch Oct 15, 2017

@vaibhavsagar vaibhavsagar referenced this pull request Oct 16, 2017

Merged

Test with GHC 8.2 #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment