Skip to content

Richard Gibson
gibson042

Organizations

@jquery
May 30, 2016
gibson042 commented on issue jquery/qunit#787
@gibson042

I don't think implementing TODO should require breaking changes to the module callback data, even though those breaking changes may be independentl…

May 30, 2016
gibson042 commented on pull request jquery/qunit#1002
@gibson042

I'd prefer a boolean—and per the above, it's probably test.resumed (this property doesn't leak to consumers, does it?).

May 30, 2016
gibson042 commented on pull request jquery/qunit#1002
@gibson042

This should guard the begin(), not the setTimeout. I believe the logic here will break down when a test's assert.async()s fail to resolve within 13…

May 30, 2016
gibson042 commented on pull request jquery/qunit#1002
@gibson042

👏

May 30, 2016
gibson042 commented on pull request jquery/jquery#3134
@gibson042

Only if someone repurposes it, but point taken.

May 29, 2016
gibson042 commented on pull request jquery/jquery#3134
@gibson042

If there's going to be a variable anyway, why not introduce it earlier?

May 29, 2016
gibson042 opened pull request Kozea/Multicorn#150
@gibson042
Expand the scope and capability of column type conversion
2 commits with 27 additions and 6 deletions
May 29, 2016
@gibson042
  • @gibson042 0aa26b5
    Expand the scope and capability of column type conversion
May 29, 2016
May 29, 2016
@gibson042
MS-SQL TEXT(N) converts to invalid Postgres TEXT(N)
May 29, 2016
gibson042 opened pull request Kozea/Multicorn#148
@gibson042
Import views along with tables
1 commit with 1 addition and 0 deletions
May 29, 2016
@gibson042
  • @gibson042 0031d1d
    Import views along with tables
May 29, 2016
May 29, 2016
@gibson042
MS-SQL Views are not copied by IMPORT FOREIGN SCHEMA
May 28, 2016
gibson042 commented on pull request jquery/jquery-migrate#196
@gibson042

I have to say I hadn't thought of intercepting the console. Obviously that would require unmuting jquery-migrate, and adding the wrapper in that i…

May 28, 2016
gibson042 commented on pull request jquery/jquery-migrate#196
@gibson042

I'd consider it bad form to leak global events, but would be happy to see a hook that gets invoked here, including event emitter style (e.g., jQuer…

May 28, 2016
gibson042 commented on pull request jquery/jquery-migrate#196
@gibson042

I agree with @mgol; this is completely redundant.

May 28, 2016
gibson042 commented on pull request jquery/jquery-migrate#196
@gibson042

I made the mistake of using my actual full name instead of my github username when signing the CLA. How do I fix those commits? You can rewrite b…

May 27, 2016
gibson042 commented on issue jquery/sizzle#174
@gibson042

The team opted not to include Sizzle 2.3 in jQuery 2.x, but you can get this particular improvement by loading Sizzle yourself and copying over the…

May 24, 2016
gibson042 closed pull request jquery/sizzle#330
@gibson042
Build: Update grunt-jscs
May 24, 2016
gibson042 commented on pull request jquery/sizzle#330
@gibson042

I'm closing this. An ESLint replacement would be welcomed, which I can do later if no one else is interested.

May 20, 2016
gibson042 commented on pull request jquery/sizzle#381
@gibson042

Comment nodes are not valid input... how did you encounter this situation?

May 19, 2016
gibson042 commented on issue lodash/lodash#2354
@gibson042

Would you be up for creating a PR to cap the limit to 307 with a unit test. That's an arbitrary cutoff, since the input to Math functions depends…

May 19, 2016
gibson042 commented on pull request jquery/qunit#998
@gibson042

the reporter is the only context in which the fixture stuff makes sense… the original goal was two fold: stop coupling Core to HTML Reporter and a…

May 19, 2016
gibson042 commented on pull request jquery/qunit#998
@gibson042

Both of these "test markup" strings should be originalValue (I knew I was missing something).

May 17, 2016
@gibson042

Perhaps we could create a Thenable type since it would be used to define this property and also for the input type of jQuery.when()? I like that.…

May 17, 2016
gibson042 commented on issue jquery/jquery#2709
@gibson042

It's targeting 4.0, in which this might be possible. I have no strong feelings about keeping this issue open.

May 17, 2016
gibson042 commented on issue jquery/qunit#1000
@gibson042

I don't think we need to go to the trouble of complicating setUrl, but I approve of more liberal decoding.

May 17, 2016
gibson042 commented on pull request jquery/qunit#1001
@gibson042

The spacing is off here. We allow up to 100 characters per line (where tab width is 4), so it might fit on one. But if not, please align it with th…

Something went wrong with that request. Please try again.