From 5333edd251cf91bed0070ba6bdec522172530ea6 Mon Sep 17 00:00:00 2001
From: ZaidMaslouhi <zaid.maslouhi@gmail.com>
Date: Wed, 20 Mar 2024 23:18:30 +0000
Subject: [PATCH] fix: :bug: remove duplication within the selected columns
 array

issue #32
---
 .../crud-typeorm/src/typeorm-crud.service.ts     | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/packages/crud-typeorm/src/typeorm-crud.service.ts b/packages/crud-typeorm/src/typeorm-crud.service.ts
index e65c7934..1580f9ec 100644
--- a/packages/crud-typeorm/src/typeorm-crud.service.ts
+++ b/packages/crud-typeorm/src/typeorm-crud.service.ts
@@ -647,9 +647,11 @@ export class TypeOrmCrudService<T> extends CrudService<T, DeepPartial<T>> {
         : allowedRelation.allowedColumns;
 
       const select = [
-        ...allowedRelation.primaryColumns,
-        ...(isArrayFull(options.persist) ? options.persist : []),
-        ...columns,
+        ...new Set([
+          ...allowedRelation.primaryColumns,
+          ...(isArrayFull(options.persist) ? options.persist : []),
+          ...columns,
+        ]),
       ].map((col) => `${alias}.${col}`);
 
       builder.addSelect(Array.from(new Set(select)));
@@ -985,9 +987,11 @@ export class TypeOrmCrudService<T> extends CrudService<T, DeepPartial<T>> {
         : allowed;
 
     const select = [
-      ...(options.persist && options.persist.length ? options.persist : []),
-      ...columns,
-      ...this.entityPrimaryColumns,
+      ...new Set([
+        ...(options.persist && options.persist.length ? options.persist : []),
+        ...columns,
+        ...this.entityPrimaryColumns,
+      ]),
     ].map((col) => `${this.alias}.${col}`);
 
     return Array.from(new Set(select));