New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'ext's detected #3

Open
iamthelowercase opened this Issue Nov 21, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@iamthelowercase

Firefox 25
KeySnail 2.0.1
Tree Style Tab 0.14.2013100901
TabSnail 1.0.6

I can't seem to find any ext's from TabSnail in the options window (preferences dialog).

As a result, I find myself not able to do anything with it. Maybe I'm doing something wrong.

I ran:
'TreeStyleTabService' in window
in the javascript console after looking at the code, and it returned false. I thought that might be the problem. But after looking at the code again, that should only affect some of the ext's.

@michael-heerdegen

This comment has been minimized.

Show comment
Hide comment
@michael-heerdegen

michael-heerdegen Dec 14, 2013

Indeed. Without having changed anything in my settings, tabsnail stopped working for me. I.e., all my bindings to any tabsnail ext results in an "ext ... not found" message. Firefox 24.

Indeed. Without having changed anything in my settings, tabsnail stopped working for me. I.e., all my bindings to any tabsnail ext results in an "ext ... not found" message. Firefox 24.

@michael-heerdegen

This comment has been minimized.

Show comment
Hide comment
@michael-heerdegen

michael-heerdegen Dec 14, 2013

Just edited tabsnail.ks.js and removed everything starting from

const SampleBinding = ...

There is some problem in this code, because after restarting firefox ... the so modified tabsnail works again!

Just edited tabsnail.ks.js and removed everything starting from

const SampleBinding = ...

There is some problem in this code, because after restarting firefox ... the so modified tabsnail works again!

@iamthelowercase

This comment has been minimized.

Show comment
Hide comment
@iamthelowercase

iamthelowercase Dec 16, 2013

Fix confirmed, with following notes:

  • Deleting just the "const SampleBinding = ..." part won't fix it. I did delete everything after that line, and that worked.
  • It's not actually necessary to restart Firefox, reloading the plugin from keysnails' plugins manager will work just as well.

My "eyeball diff" on the two existing forks of TabSnail makes me think they don't have this fix. I'll fork and post a changed version.

Fix confirmed, with following notes:

  • Deleting just the "const SampleBinding = ..." part won't fix it. I did delete everything after that line, and that worked.
  • It's not actually necessary to restart Firefox, reloading the plugin from keysnails' plugins manager will work just as well.

My "eyeball diff" on the two existing forks of TabSnail makes me think they don't have this fix. I'll fork and post a changed version.

iamthelowercase added a commit to iamthelowercase/TabSnail that referenced this issue Dec 16, 2013

Fixed (patched?) gifnksm#3, perhaps in the stupidest way possible.
TabSnail will (should) now work with FF 24+ and KeySnail 2.0.1+
Thanks to Michael Heerdegen for discovering the workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment