Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
Commits on Dec 31, 2012
@ruz ruz extract Transaction->QuoteHeader method
Code that is adding "On <date> <person> wrote:" in front of
quoted context is burried in other method, so it's hard to
change style of the quoting. Extract it into a new method.
Commits on Jan 22, 2013
sunnavy parse cf date in user's timezone to make it right for strings like "t…
…oday", "tomorrow", etc
Commits on Jan 31, 2013
@jibsheet jibsheet Move PageWidgets definition earlier in Elements/Tabs
By defining them at the end, nothing could change them when you click
into a different part of the UI.  Articles used to provide a default
search under /Articles/ and this allows that to work again.
@jibsheet jibsheet Update GotoArticle to act more like GotoTicket
This removes the button and hints in the box what to search for instead.
@jibsheet jibsheet Add GotoArticle and remove the Ticket page widgets when in /Articles
This means you can't trivially create a ticket when working on Articles,
but having two search boxes and moving the two normal search boxes
around felt even more confusing.
@jibsheet jibsheet Removing CreateTicket/SimpleSearch renumbered forms
The article tests are made of form_number and want to start using
form_name, but I didn't want to tackle it all on this branch.
Commits on Feb 08, 2013
@alexmv alexmv Make subject tag be non-greedy, to not match all of "[comment] [foo #1]" b68179c
Commits on Feb 11, 2013
@ruz ruz don't create DB if we run perl -c on a test file f0e57ea
Commits on Feb 25, 2013
sunnavy tests for /Admin/User/GnuPG.html 1f77b83
Commits on Feb 27, 2013
@tsibley tsibley Use a tiny comment to fix vim's syntax highlighting 292dd3b
@tsibley tsibley Callbacks for changing the link destinations in the queue summaries
While likely to be used only rarely, these callbacks are very useful for
extensions which provide a richer "queue dashboard" than the vanilla
search results normally linked to by the queue summary portlets.
Without the callbacks, such extensions are forced to overlay the entire
files just to change some URLs.

The duplication between the two types of queue summaries is unfortunate,
but large scale refactoring is out of scope for the simple goal of this
commit.  A future refactoring isn't hampered any by the additional
Commits on Feb 28, 2013
@tsibley tsibley Add a callback for modifying the displayed queues on the quicksearch …

This also lets the callback skip the ShowTicket rights check or specify
a different right.
@giganteous Fix a wording in the documentation string 777fbe9
@tsibley tsibley Escape menu URLs, targets, and IDs when generating HTML
Using proper escaping is simply a precaution in this case.  None of the
unescaped interpolation is actually reachable for malicious purposes.

Notably, menu item ->path values are appropriately sanitized thanks to
being passed through in RT::Interface::Web::Menu.  Targets and
IDs are not used with user-input.

The escaping is bulletproofing, and there's no reason not to.
Commits on Mar 01, 2013
@alexmv alexmv Merge branch '4.0/queue-summary-link-callbacks' into 4.0-trunk f06d2b2
@alexmv alexmv Fix the class whose id existance we're checking c8c468f
@alexmv alexmv Merge branch '4.0/restore-article-quicksearch' into 4.0-trunk d81619c
@tsibley tsibley Fixup some POD links/file references
L<> shouldn't be used with file paths and F<> should be used for docs/
references.  Adjusts an internal link within RT::Shredder; only one
section must be referred to in a link.
Commits on Mar 02, 2013
@tsibley tsibley Respect plain text display preferences for all plain text content
Attachments with filenames are never parsed with Text::Quoted, so the
passed in $Message content was never an array reference.  This caused
textual attachments to ignore the PlainTextPre and PlainTextMono
settings, the symptom of which is nigh unreadable text.  Moving those
preferences out of the conditional corrects the display.  Now every call
to ShowMessageStanza with a text/plain content type will result in a
<div class="message-stanza">, which may be white-space preserving and/or
wrapped in a <pre>.
Commits on Mar 04, 2013
@tsibley tsibley Merge branch 'giganteous:4.0/documentation-rtaction-recordcorresponde…
…nce' into 4.0-trunk

Pull request 46.
Commits on Mar 05, 2013
sunnavy make login inputs the same length especially for ie8/9.
see also #17159
Commits on Mar 07, 2013
@alexmv alexmv Merge branch '4.0/test-admin-user-gnupg' into 4.0-trunk 91c6c74
@alexmv alexmv Merge branch '4.0/quicksearch-prefs-callback' into 4.0-trunk 12d2919
@alexmv alexmv Merge branch '4.0/escape-more-menu-attributes' into 4.0-trunk 7e11127
@tsibley tsibley Allow mailto: links in HTML
This is useful for HTML email which includes linked email addresses and
also search formats which want to use a value in a mailto: link for
convenience.  There is no harm in mailto: links.
Commits on Mar 08, 2013
@tsibley tsibley An invalid "results=" parameter is not a CSRF threat
Since results keys are removed from the session once they're used,
refreshing a page with a results= parameter would throw up the CSRF
interstitial.  That behaviour is almost as bad as a browser asking if
you want to resubmit the POST data on refresh, which is the reason for
the MaybeRedirectForResults() framework in the first place.
Commits on Mar 11, 2013
@tsibley tsibley Add callbacks for the mobile login form equivalent to the non-mobile …
Commits on Mar 12, 2013
@bergonz bergonz Fix for typo
The typo was generating some 'Use of uninitialized value in join or string'
@ruz ruz test subject tag extraction is not greedy 856fad1
@ruz ruz Merge branch '4.0/non-greedy-extract-subject-tag' into 4.0-trunk af4711a
@tsibley tsibley Merge remote-tracking branch 'github/pr/48' into 4.0-trunk e53f597
Commits on Mar 13, 2013
sunnavy Merge branch '4.0/admin-class-pagemenu' into 4.0-trunk 556f81d
@ruz ruz test CF's context via UI
there was a bug that CF value was set to "no value" on submit if
CF rights are granted via queue and CF is not changed.
@ruz ruz test that Date CFs are parsed properly
test API, check both abosolute and relative variants
@ruz ruz Merge branch '4.0/parse-cf-date-in-user-timezone' into 4.0-trunk d0193ef
@ruz ruz skip DB interaction in gpg tests during syntax check
RT::Test::GnuPG adds rights from 'sub import', skip it
during perl syntax check
Commits on Mar 14, 2013
@ruz ruz ValuesClass was missing from *Accessible
it was changed from attribute to column
@ruz ruz any false ValuesClass should be valid
RT::CustomField->ValidateValuesClass must allow "0" as
RT::Record->_Set replace undef value by 0
Emmanuel Lacour Fix CF ValuesClass update in web UI
* update only if needed
* display localized update result
Emmanuel Lacour tests around RT::CustomField->SetValuesClass
UI and API
@giganteous Add documentation to RT::Action::ExtractSubjectTag 313eb19
@jibsheet jibsheet Cleanups and Clarification of new ExtractSubjectTag docs
Explain a little more about how it works (changing the Ticket), podify
in a few places and a few minor grammatical nits.
@jibsheet jibsheet Pull down an update from Launchpad and re-export
This includes updates to Catalan by Ton Orga Ventura
that provide enough translations for us to ship it in core now.
@ruz ruz delete shebang string from test 81fc7cb
@alexmv alexmv Merge branch '4.0/dont-create-db-for-syntax-check' into 4.0-trunk 9c51da5
@jibsheet jibsheet Exclude wasn't working with more than one record
This was generating (id != 7 OR id != 9) which gleefully returns both 7
and 9. Switch over to an ENTRYAGGREGATOR of AND. This is exposed in the
Membership page of Groups. Groups with one user had that user excluded
from the member autocomplete, but as soon as you have two members that
stopped working (same for groups).
Commits on Mar 15, 2013
@cbrandtbuffalo cbrandtbuffalo Die when detecting SetHandler perl-script 033dd96
@alexmv alexmv Ensure that the error message is logged with newlines
die() is verridden somewhere in the stack to s/\n/\\n/g; this makes the
error message much less readable.

Use a direct call to $RT::Logger to ensure that newlines are preserved,
which also allows us to set the log level explicitly.  Not exiting via
die() requires that we handle providing the HTTP response by hand, which
also provides the opportunity to explicitly call out the
@alexmv alexmv Merge branch '4.0/allow-mailto-links-in-html' into 4.0-trunk 85c2d24
@alexmv alexmv Merge branch '4.0/login-inputs-length' into 4.0-trunk 8c90b68
@alexmv alexmv Merge branch '4.0/extract-quote-header-method' into 4.0-trunk 40cb640
@alexmv alexmv Merge branch '4.0/mobile-login-callbacks' into 4.0-trunk 986b1f2
@alexmv alexmv Merge branch '4.0/test-CF-context' into 4.0-trunk dfc6123
@alexmv alexmv Merge branch '4.0/fix-cf-valuesclass-updates' into 4.0-trunk eaad687
Commits on Mar 18, 2013
@cbrandtbuffalo cbrandtbuffalo Merge branch '4.0/die-on-perl-script-handler' into 4.0-trunk 15692ec
@tsibley tsibley Merge branch '4.0/update-from-launchpad' into 4.0-trunk af2facd
@alexmv alexmv Minor grammar nitpicks 42a245b
@alexmv alexmv Merge branch '4.0/document-extractsubjecttag' into 4.0-trunk 2b12fb2
@alexmv alexmv Merge branch '4.0/plain-text-attachment-display' into 4.0-trunk a35a117
Commits on Mar 19, 2013
@tsibley tsibley Ensure action results are deleted from the session upon first use
This removes the inconsistent display of action results after a page
reload and keeps the session from growing unbounded.  Previously the
delete didn't update the session store unless a subsequent component
incremented the session counter.  Quick ticket creation does not, for
@tsibley tsibley Test that action results are only displayed once and don't trigger CSRF 67cca06
sunnavy tests for the cf date parse in search using RT::Date 0f4023d
@NetSandbox NetSandbox remove non-existing style id's
This is an leftover from RT 3.8 menu.
@NetSandbox NetSandbox remove always the right element from titlebox
This element contains information that never would be worth printing.
@NetSandbox NetSandbox Fix display of numbers for german language d6c77df
sunnavy use RT::Date to parse cf date values in tickets search
to distinguish if user inputs date or datetime, here is the rule:

1. if cf type is Date, it's a date.

2. if cf type is DateTime, unless there is "hh:mm:ss" or "midnight", as
long as the parsed time is at midnight(00:00:00), it's a date.

we treat midnight datetimes as dates sometimes specially is because if user
searches a DateTime cf with a value like '=' '2013-03-21', we assume he means to
get all the tickets with the cf values in the range of the whole day.
sunnavy the whole day search for a datetime cf should be a right open interval
if user searches a DateTime cf with '=' '2012-03-21', we should limit the
cf values '>=' '2012-03-21 00:00:00' and '<' '2012-03-22 00:00:00', i.e.

[ '2012-03-21 00:00:00', '2012-03-22 00:00:00' )
Commits on Mar 20, 2013
@NetSandbox NetSandbox switch from tr to set numf_comma 47c9dd1
@alexmv alexmv Merge branch '4.0/autocomplete-exclude' into 4.0-trunk 0e3c5bb
@NetSandbox NetSandbox correct #app-nav name and bring back #page-menu
as suggested by tsibley
Commits on Mar 21, 2013
@alexmv alexmv Merge branch '4.0/allow-any-results-param-by-csrf' into 4.0-trunk 27428ec
@tsibley tsibley Merge remote-tracking branch 'github/pr/53' into 4.0-trunk ca919c1
@tsibley tsibley Merge remote-tracking branch 'github/pr/52' into 4.0-trunk 5f26708
Commits on Mar 28, 2013
@ruz ruz add more tests around Date[Time] CFs 1cc214b
@ruz ruz Merge branch '4.0/cf-date-parse-in-search' into 4.0-trunk b9c46a4
Commits on Apr 03, 2013
@giganteous Do not dump non-userdefined groups
There really should be no reason to dump those
@giganteous Add an option to limit the users to Privileged
We have a lot of users (750k) that we don't really need
in the XML dump for testing purposes.
@giganteous Improve the ACL dumping to support names
The previous version dumps Principal ID's pointing
to ACLEquivalence groups. These are quite useless when
there are removed users (ie. rt-shredder removed some users)
or when you skip certain users (limit-privileged-users).

This version should dump ACLs using users' Name,
groups' Name and global Rolegroups' Name attributes.
@giganteous Small bugfix for Queue Role groups 846f209