update origin from upstream #1
Explicit require of cucumber-rails components
cucumber-rails entypoint tries to be too smart in my opinion by for example trying to boot the app for you (which we are already doing anyways and it's surprising), autodetecting the helper file that does the require and fail if it's not called `env.rb` (which I have no idea why), or throwing some warnings if certain settings are configured (which in our case leads to an unexpected warning). Let's instead only require the components we need. This change fixes the long standing warning during class reloading scenarios: ``` WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb). This setting is known to cause problems with database transactions. Set config.cache_classes to true if you want to use transactions. ```
- Loading branch information...
deivid-rodriguez committedcommit ce0df9179e829faa2e7fcd2e125f07715cbd9e1f
Dec 1, 2018
ProTip! Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.