Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The primary button is not focused by default #551

Open
p-himik opened this issue Sep 29, 2019 · 1 comment
Labels

Comments

@p-himik
Copy link

@p-himik p-himik commented Sep 29, 2019

馃悰 Bug Report

The primary button is not focused.
I assume that it should be, given this code:

this.scope = new Scope(this.tooltip, { selector: '[data-action=primary]' });
this.scope.setFocus();

To Reproduce

You can easily check it at https://react-joyride.com/
Note that the very first step still has focus at its primary button. It seems to be because the target is the body - I have the same behavior in my own project.

Expected behavior

The primary button should be focused by default at each step.

@danielimmke

This comment has been minimized.

Copy link

@danielimmke danielimmke commented Oct 6, 2019

@gilbarbara Hello I have a PR in for this if you have a moment to review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.