Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loaded contents in iframes are not saved on Medium #779

Open
mwnoo opened this issue Sep 14, 2021 · 3 comments
Open

Lazy loaded contents in iframes are not saved on Medium #779

mwnoo opened this issue Sep 14, 2021 · 3 comments

Comments

@mwnoo
Copy link

@mwnoo mwnoo commented Sep 14, 2021

Describe the bug
Lazy loading elements (GitHub gists, youtube links) are not captured using docker singlefile
In the output these elements are blank

To Reproduce
Steps to reproduce the behavior:

  1. docker run singlefile "https://towardsdatascience.com/how-to-train-a-bert-model-from-scratch-72cfce554fc6" > bert.html
  2. docker run singlefile "https://towardsdatascience.com/how-to-train-a-bert-model-from-scratch-72cfce554fc6" > bert.html --load-deferred-images-max-idle-time 8000

Expected behavior
The elements containing embedded code blocks (gists) from Github and youtube links should be visible in the output

Environment

  • OS: Ubuntu 20.04.3
  • singlefile docker image

Additional context
Using the FireFox extension I have the same issue when I only open the page and run singlefile. When I scroll down the page and then run singlefile some of the elements are captured in the output. But this seems not possible with the docker version of singlefile.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Sep 17, 2021

I confirm the issue and it's not specific to docker. I'll try to see what's wrong even though I'm tired of trying to understand how the lazy loading works on Medium. It's like they're trying really hard to make my life more complicated. This could be cicurmvented with a user script which would scroll to the end of the page.

@gildas-lormeau gildas-lormeau changed the title Lazy loading elements are not captured using docker version Lazy uploaded contents are not saved on Medium Sep 17, 2021
@gildas-lormeau gildas-lormeau changed the title Lazy uploaded contents are not saved on Medium Lazy loaded contents are not saved on Medium Sep 17, 2021
@mwnoo
Copy link
Author

@mwnoo mwnoo commented Sep 18, 2021

I understand how difficult it is to keep up with all those performance tweaks websites implement these days and I really appreciate all the time and effort you put into this amazing tool. SingleFile is a great tool!

@WellRedPandit
Copy link

@WellRedPandit WellRedPandit commented Sep 18, 2021

cicurmvented with a user script which would scroll to the end of the page

@gildas-lormeau , would you be kind enough to sketch out such a script? or point to a script of this kind you may know of? i'm not a front-end developer, so it's a bit hard for me to come up with one, but i would love to test it out in chrome and firefox.

and thank you again for your great extension!

@gildas-lormeau gildas-lormeau changed the title Lazy loaded contents are not saved on Medium Lazy loaded contents in iframes are not saved on Medium Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants