Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug where space for videos appears to be allocated twice #793

Open
russellyoung opened this issue Oct 6, 2021 · 1 comment
Open

Minor bug where space for videos appears to be allocated twice #793

russellyoung opened this issue Oct 6, 2021 · 1 comment

Comments

@russellyoung
Copy link

@russellyoung russellyoung commented Oct 6, 2021

Describe the bug
This is a minor bug, the web page does render properly, but with extra blank space at several spaces. I just submit it FYI.
A page that shows the issue is https://mp.weixin.qq.com/s/kGT_dmZo8Pn3uNXCWv_eoQ. Before each video there is a vertical white space the size of the video
To Reproduce
Steps to reproduce the behavior:
1: go to https://mp.weixin.qq.com/s/kGT_dmZo8Pn3uNXCWv_eoQ
2: After it renders use singlefile to save a copy
3: display the copy
4: scroll down past the first image to the second, which is a video. There is a vertical whitespace the height of the video in the saved version that is not there in the original

Expected behavior
there should not be the extra whitespace

Screenshots
Original page screenshot:
orig-image
Copy page screenshot:
copy-image
Original page DOM:
orig-dom
Copy page DOM:
copy-dom

Environment

  • OS: MacOS 10.14.6 (18G9323)
  • Browser: Brave
  • Version: Version 1.29.79 Chromium: 93.0.4577.63 (Official Build) (x86_64)

Additional context
In the DOM screenshot you can see there is an extra element (div id="page-content") in the copy. The video image appears in that div, while the above (p) image, which is the video on the original, is the same size as the video but blank

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Oct 6, 2021

Actually the <div id="page-content"> is present in the original page but is located into the <span> element (child of <p>). I usually see this kind of issue with malformed HTML. The reason in this example is not obvious at first glance, I will take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants