Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set default path support for saving to filesystem #823

Open
scruel opened this issue Nov 18, 2021 · 10 comments
Open

Add set default path support for saving to filesystem #823

scruel opened this issue Nov 18, 2021 · 10 comments

Comments

@scruel
Copy link
Contributor

@scruel scruel commented Nov 18, 2021

Describe the solution you'd like
Able to specify the default path for saving the pages.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Nov 18, 2021

Thank you for the suggestion, I agree with you. Note that you should be able to achieve this with the filename template but I can understand that it is not very practical.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Nov 18, 2021

Again, I forgot this option already exists... The option --output-directory should do the job. Regarding the extension, they cannot save pages outside the download folder.

@scruel
Copy link
Contributor Author

@scruel scruel commented Nov 19, 2021

Again, I forgot this option already exists... The option --output-directory should do the job. Regarding the extension, they cannot save pages outside the download folder.

OK, but this option is only for CLI now, not for the browser plugin when saving in file system.
For browser plugin, I can only select one destination for saving pages now.
But sometimes I want to save to multiple destinations for backup reason(with an option "no need to show the 'save as' dialog"), so may change the radio to checkbox for destinations will be better.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Nov 21, 2021

Extensions cannot write files outside the Downloads folder. However you can use the filename template to save pages into sub-folders. Note also that you could use profiles to define different sub-folders. For example, you could create a profile named "backup" with a filename template beginning with backup/.

@mjrawesome
Copy link

@mjrawesome mjrawesome commented Dec 27, 2021

For example, you could create a profile named "backup" with a filename template beginning with backup/.

Unfortunately, this doesn't work for me. I navigated to "Extension options" -> "File name" -> "template" and changed the default settings to "backup/{day-locale}.{month-locale}.{year-locale}.html". The slash is replaced by an underscore and it is still saved into the same, main Downloads folder.

system info

Windows 7 (64x)
Chrome v96.0.4664.110
SingleFile Extension v1.19.24

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 28, 2021

Please make sure Misc. > save pages in background is enabled.

@mjrawesome
Copy link

@mjrawesome mjrawesome commented Dec 28, 2021

Please make sure Misc. > save pages in background is enabled.

Thanks for an ultra fast reply. I enabled the setting in Misc, but the file is still saved into the same directory. Except now the file name doesn't seem to follow the template at all (e.g. with "backup/{year-locale}.html", I get "574f1233-b013-45f2-a608-8232dbead111.htm" instead of "2021.html").

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 28, 2021

This is unfortunately a bug in Chrome, see https://bugs.chromium.org/p/chromium/issues/detail?id=892133. Using a separate/new profile might help. There is nothing I can do to fix it on my end. Note that this bug is specific to Chomium-based browsers.

@mjrawesome
Copy link

@mjrawesome mjrawesome commented Dec 28, 2021

@gildas-lormeau
This is very unfortunate and it will likely affect other Chromium-based browsers, like Opera (confirmed by me), Edge (not tested), Samsung Internet Browser (not tested), which only leaves Safari and Firefox of the popular ones.

I don't have the same problem with either "DownloadThemAll" or "Simple mass downloader", both of which seem to save into subdirectories just fine. Perhaps a similar solution could be implemented here.

At any rate, thank you for creating and maintaining this otherwise excellent extension.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 28, 2021

Actually "DownloadThemAll" or "Simple mass downloader" might be probably the cause of this bug. I know that there is more chances to see it when download managers are installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants