Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you feel about using Rough Notation in SingleFile to make the annotations 'pop' more ? #836

Open
Welding-Torch opened this issue Dec 11, 2021 · 3 comments

Comments

@Welding-Torch
Copy link

@Welding-Torch Welding-Torch commented Dec 11, 2021

So I cam across this library called 'Rough Notation', and I thought I'd bring it to the attention of the developers of SingleFile
because it might be interesting to think about implementing this into SingleFile annotations. It's small, it's fast, and it looks really good! https://roughnotation.com/

If the devs feel that this isn't something they wanna add to their plate, that's totally fine. I just wanted to let you know about this tool's existence.

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 13, 2021

Thank you for the suggestion. The problem I see with the library is that I'm not sure it would handle selections across multiple paragraphs (for example when using the "box" or "circle" styles). Moreover the library does not offer the technical part responsible for the selection with the mouse, which would make the integration a bit complicated. Finally, it also requires an evolution of the toolbar to integrate the variants. Overall, I'm not against the idea of enriching the highlighting function but I'm not sure this library would be used as is, it could serve as a source of inspiration though.

@Welding-Torch
Copy link
Author

@Welding-Torch Welding-Torch commented Dec 14, 2021

Thank you for taking the time to actually consider the idea fully. All those 3 reasons make a lot of sense. I agree, it does make more sense to use this as an inspiration.

Thanks again!

@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 14, 2021

We can keep the issue open, so that we can remember this need ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants