Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with two websites (failure to save pages, or to save embedded images) #843

Open
abolibibelot1980 opened this issue Dec 17, 2021 · 1 comment

Comments

@abolibibelot1980
Copy link

@abolibibelot1980 abolibibelot1980 commented Dec 17, 2021

  1. SingleFile always fails to save pages from Vavideo.de, getting stuck at step 1.
    Example :
    https://www.vavideo.de/inhalt?id=2793445
    Save Page WE works fine on this website.

  2. SingleFile fails to save embedded images from Indexxx.com, this even if making sure that all images have been loaded in the browser before proceeding to save the page.
    Example (kinda NSFW) :
    https://www.indexxx.com/m/mia-sollis
    When reloading the saved page into Firefox, I can see that all embedded pictures are blank.
    (It should be noted that downloading the actual cover pictures from that website is tricky, I made a curl script to batch download those from that page, for it to work each command had to include a time-limited "cookie" element obtained from the browser's network analyser.)
    Save Page WE issues a warning saying that (for instance) “217 of 339 resources could not be loaded” (and the resulting file likewise does not include the pictures even though it's about twice as large as the one produced by SingleFile), so it doesn't work well either but at least it lets the user know it right away that something is wrong. Generally speaking, even for issues that can't be fixed, displaying that kind of warning would be welcome.

Environment

  • OS: Windows 7 Pro
  • Browser: Firefox 95 64 bits
gildas-lormeau added a commit that referenced this issue Dec 17, 2021
@gildas-lormeau
Copy link
Owner

@gildas-lormeau gildas-lormeau commented Dec 17, 2021

Thank you, I fixed the first issue, the fix will be available in the next version. Meanwhile, you can circumvent it by disabling the setting Stylesheets > compress CSS content in the options page of SingleFile (it's disabled by default). I'm not 100% sure this was your bug though since I don't know your settings.

I have mixed feelings about the second issue. The problem is false negatives. I have already tested the extension you mention and I personally find the warning window annoying. Most of the time the page is intact while the popup indicates that some resources have not been saved. I don't want to provide this kind of user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants