Updated kotlin to 1.2.41 and coroutines to 0.23.1. #39
Conversation
build.gradle.kts
Outdated
| compile("org.jetbrains.kotlinx:kotlinx-coroutines-core:0.22.5") | ||
| compile("com.squareup.retrofit2:retrofit:2.4.0") | ||
| testCompile("junit:junit:4.12") | ||
| implementation("org.jetbrains.kotlin:kotlin-stdlib") |
There was a problem hiding this comment.
Please, do not use implementation configuration for stdlib and other dependencies. We do not want to hide stdlib from transitive dependencies
Use compile instead (api configuration is not available without java-library Gradle plugin and not a better than compile in this case)
| * | ||
| * @return Result of request or throw exception | ||
| */ | ||
| public suspend fun <T : Any> Call<T>.await(): T { |
There was a problem hiding this comment.
Please return back all explicit public modifiers.
| import kotlinx.coroutines.experimental.Unconfined | ||
| import kotlinx.coroutines.experimental.async | ||
| import kotlinx.coroutines.experimental.runBlocking | ||
| import kotlinx.coroutines.experimental.* |
|
Thanks for your contibution, I added a few comments. If you want to release it soon, please also update README.md and CHANGELOG.md. And I will release it |
….23.0, where CoroutineScope.coroutineContext was deprecated and replaced with top-level function.
…ored code to use invokeOnCancellation instead.
bohsen
changed the title
|
Updated pull request based on comments. |
|
Thanks, merged, will bump version to 0.11 and publish |
2 participants
This update fixes issues caused by breaking changes in kotlin coroutines 0.23.0: