Permalink
Browse files

Still getting false positives. I added more fake data to reflect this…

… and recreate the bug, but no dice. Then I added the .uniq and the bug is gone. Unfortunately I can't just pop the data I found the bug with into git, because I'm using a few crufty client/ex-client apps to develop this on.

I'm going to have to find where this bug came from, I think, because there's a good chance the .uniq won't work when I expand the diff stuff. Right now the diff is interesting but you have to do it directly via the codebase model, you can't do it via a Towelie object. No nice views, either, and the lack of useful metadata is a problem. For the diff to be useful, at a minimum, it has to say what a given method definition is different *from*.
  • Loading branch information...
gilesbowkett committed Oct 6, 2008
1 parent 2148419 commit cf2449822b00b3e0c5d94d1eef94516e7b82f97f
Showing with 9 additions and 1 deletion.
  1. +1 −1 lib/array.rb
  2. +8 −0 spec/diff_false_positives/app/models/muppet_balls.rb
View
@@ -15,6 +15,6 @@ def comparing_collect
stepwise do |element1, element2|
accumulator << element1 if yield(element1, element2)
end
- accumulator.compact
+ accumulator.compact.uniq
end
end
@@ -0,0 +1,8 @@
+class MuppetBalls < Wtf
+ def recent
+ find(:all)
+ end
+ def dropdown
+ find(:all).collect { |u| [u.name, u.name] }
+ end
+end

0 comments on commit cf24498

Please sign in to comment.