New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add copyright statement (including years) to source. #25

Closed
onlyjob opened this Issue Apr 14, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@onlyjob

onlyjob commented Apr 14, 2015

src/jquery.nearest.js is missing copyright statement. Unfortunately link to license is not sufficient... Thanks.

@gilmoreorless

This comment has been minimized.

Show comment
Hide comment
@gilmoreorless

gilmoreorless Apr 15, 2015

Owner

Out of interest, why is a link to the licence not sufficient? jQuery itself only contains a link to its licence, not the full text: http://code.jquery.com/jquery-2.1.3.js

Owner

gilmoreorless commented Apr 15, 2015

Out of interest, why is a link to the licence not sufficient? jQuery itself only contains a link to its licence, not the full text: http://code.jquery.com/jquery-2.1.3.js

@onlyjob

This comment has been minimized.

Show comment
Hide comment
@onlyjob

onlyjob Apr 15, 2015

IMHO jQuery is not following best practice. For instance they include link to their own site (instead of the http://opensource.org/licenses/MIT ) so one should open the link to make sure it is really what they meant by "MIT" license;

Free Software Foundation considers "MIT License" ambiguous because it refers to different licenses:

In your case only text of the license contains copyright statement. You can include copyright statement to .js file header accompanied by link to the text of the license but text of license is short so it will take only little space. For software which is often embedded to other projects It is good to document licensing terms and copyright clearly.

onlyjob commented Apr 15, 2015

IMHO jQuery is not following best practice. For instance they include link to their own site (instead of the http://opensource.org/licenses/MIT ) so one should open the link to make sure it is really what they meant by "MIT" license;

Free Software Foundation considers "MIT License" ambiguous because it refers to different licenses:

In your case only text of the license contains copyright statement. You can include copyright statement to .js file header accompanied by link to the text of the license but text of license is short so it will take only little space. For software which is often embedded to other projects It is good to document licensing terms and copyright clearly.

@onlyjob

This comment has been minimized.

Show comment
Hide comment
@onlyjob

onlyjob Apr 15, 2015

Also there is an obvious reason to include license instead of a link: imagine situation when some time later project changed hosting or taken down and bundled copies of script links to dead URL... I've seen many such cases where it is hard to assess license compatibility or even to check whether re-distribution is allowed...

onlyjob commented Apr 15, 2015

Also there is an obvious reason to include license instead of a link: imagine situation when some time later project changed hosting or taken down and bundled copies of script links to dead URL... I've seen many such cases where it is hard to assess license compatibility or even to check whether re-distribution is allowed...

@gilmoreorless

This comment has been minimized.

Show comment
Hide comment
@gilmoreorless

gilmoreorless Apr 26, 2015

Owner

OK, I've added a LICENSE.txt file in the root of this repository (and therefore on the documentation site as well).
I've also updated the js file comment headers to include years of copyright and a link to the hosted version of LICENSE.txt

In order to keep with the "don't ever modify a release" rules of semver, I've released version 1.3.1 with the new comment headers.

Let me know if there are any problems with this new wording. :)

Cheers,
Gil

Owner

gilmoreorless commented Apr 26, 2015

OK, I've added a LICENSE.txt file in the root of this repository (and therefore on the documentation site as well).
I've also updated the js file comment headers to include years of copyright and a link to the hosted version of LICENSE.txt

In order to keep with the "don't ever modify a release" rules of semver, I've released version 1.3.1 with the new comment headers.

Let me know if there are any problems with this new wording. :)

Cheers,
Gil

@onlyjob

This comment has been minimized.

Show comment
Hide comment
@onlyjob

onlyjob Apr 26, 2015

All good, thank you. :)

onlyjob commented Apr 26, 2015

All good, thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment